Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor builders #249

Merged
merged 7 commits into from
Nov 27, 2024

move remaining definitions

21d3ad6
Select commit
Loading
Failed to load commit list.
Merged

refactor builders #249

move remaining definitions
21d3ad6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 27, 2024 in 0s

65.64% (-0.01%) compared to 255abf2, passed because coverage increased by 1.90% when compared to adjusted base (63.74%)

View this Pull Request on Codecov

65.64% (-0.01%) compared to 255abf2, passed because coverage increased by 1.90% when compared to adjusted base (63.74%)

Details

Codecov Report

Attention: Patch coverage is 74.38541% with 323 lines in your changes missing coverage. Please review.

Project coverage is 65.64%. Comparing base (255abf2) to head (21d3ad6).

Files with missing lines Patch % Lines
biscuit-auth/src/token/builder/block.rs 60.71% 77 Missing ⚠️
biscuit-auth/src/token/builder/term.rs 74.57% 75 Missing ⚠️
biscuit-auth/src/token/builder/rule.rs 75.23% 53 Missing ⚠️
biscuit-auth/src/token/builder/expression.rs 82.75% 30 Missing ⚠️
biscuit-auth/src/token/builder/biscuit.rs 67.16% 22 Missing ⚠️
biscuit-auth/src/token/builder/algorithm.rs 15.00% 17 Missing ⚠️
biscuit-auth/src/token/builder/fact.rs 78.75% 17 Missing ⚠️
biscuit-auth/src/token/builder/check.rs 88.04% 11 Missing ⚠️
biscuit-auth/src/token/builder/policy.rs 85.29% 10 Missing ⚠️
biscuit-auth/src/token/builder/scope.rs 71.42% 8 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##               v5     #249      +/-   ##
==========================================
- Coverage   65.65%   65.64%   -0.01%     
==========================================
  Files          27       38      +11     
  Lines        6994     6995       +1     
==========================================
  Hits         4592     4592              
- Misses       2402     2403       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov