Authorizer API improvements #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #255 will not alter performanceComparing Summary
|
divarvel
commented
Dec 4, 2024
biscuit-auth/src/token/authorizer.rs
Outdated
| } | ||
|
|
||
| impl Authorizer { | ||
| pub fn run(&mut self) -> Result<Duration, error::Token> { | ||
| match self.execution_time { | ||
| Some(execution_time) => Ok(execution_time), // TODO should `run` be idempotent or raise an error if called twice? |
There was a problem hiding this comment.
run being idempotent makes it really easy to lazily trigger evaluation in either authorize or query, so it is very important to have this ability. maybe as an internal function if we really want to make sure run triggers evaluation or fails if it can’t?
There was a problem hiding this comment.
Yep it's good that this is idempotent
Geal
approved these changes
Dec 5, 2024
This allows taking a snapshot of the authorizer even if the datalog evaluation fails.
divarvel
force-pushed
the
authorizer-debug
branch
from
6246752 to
0328663
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on tests with a private project:
impl Debug for AuthorizerAuthorizereven if datalog evaluation failsthe second part is the biggest change, it makes running evaluation actually lazy (authorize and query functions ensure that evaluation is run). This allows constructing an Authorizer even if datalog evaluation fails. This is especially useful to take snapshots of failed datalog evaluations.
TODO
Option<Duration>withNotStarted | Success(Duration) | Failed(Duration)) => maybe in a next version, this would require further changes to the snapshot data structureAuthorizer::from_snapshot(), but this will require extra work, in a separate PR