Demos now grow up to 600px to fit content

[imaustink]

Fixes issue #4 and some whitespace inconsistency in the file.

[justinbmeyer]

I don't think this is going to work for when the content changes size

…

Sent from my iPhone

On Apr 13, 2017, at 11:02 AM, Austin Kurpuis ***@***.***> wrote: Fixes issue #4 and some whitespace inconsistency in the file. You can view, comment on, or merge this pull request online at: #5 Commit Summary Auto scale demos Removed unused variable File Changes M .gitignore (1) M demo_frame.js (87) Patch Links: https://github.com/bit-docs/bit-docs-tag-demo/pull/5.patch https://github.com/bit-docs/bit-docs-tag-demo/pull/5.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[leoj3n]

Ignoring .DS_Store should probably be done in your global .gitignore since it's OS dependent.

Also, it would help with review if you made sweeping whitespace changes in a different commit.

Eventually we will have some hinting/linting that will fix everything up anyways (differently), so usually I avoid reformatting a file's whitespace unless completely rewriting that file's functionality.

Once #9 is merged you shouldn't be blocked on writing tests for this.

[leoj3n]

Is this something that needs to be merged? Lmk if you need help merging since this now has conflicting changes because of a PR I just merged.

[imaustink]

@leoj3n I honestly don't remember exactly what is going on with this. I think @justinbmeyer wanted a test for this but I think at the time this was implimented we were waiting for changes in bit-docs to make it more testable.

[leoj3n]

Well, I do see that I commented:

Once #9 is merged you shouldn't be blocked on writing tests for this.

But that's kind of vague in retrospect, and I'm not entirely sure what I meant there.

I guess you were blocked in writing tests for this because of #9?

Well, #9 is closed now, if that helps.

[leoj3n]

Oh yeah, I think running the test suite with Zombie was broken and I had resolved that in my test suite PR, so you were kind of waiting for that to be merged and available to write tests on top of.

[m-mujica]

Closed in favor of #13