Reduce psalm error level to 1

psalm.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <psalm
-        errorLevel="8"
+        errorLevel="1"
         resolveFromConfigFile="true"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xmlns="https://getpsalm.org/schema/config"
@@ -12,4 +12,12 @@
     <projectFiles>
         <directory name="src"/>
     </projectFiles>
+    <issueHandlers>
+        <DeprecatedClass>
+            <errorLevel type="suppress">
+                <!-- See https://github.com/vimeo/psalm/issues/10116 -->
+                <file name="src/Command/CommandBuilderTrait.php"/>
+            </errorLevel>
+        </DeprecatedClass>
+    </issueHandlers>
 </psalm>

src/Command/AddCommandBuilder.php

@@ -175,6 +175,7 @@ public function ignoreMissing()
      */
     public function execute($pathspec = null, $_ = null)
     {
+        /** @var list<string> $args */
         $args = \func_get_args();
         if (\count($args)) {
             $this->arguments[] = '--';

src/Command/BranchCommandBuilder.php

@@ -336,27 +336,26 @@ public function execute($branchName = null)
         if ($branchName) {
             $this->arguments[] = $branchName;
         }
-        return $this->run();
+        return (string) $this->run();
     }
 
     /**
      * Retrieve the branch names.
      *
-     * @return string[]
+     * @return list<string>
      */
     public function getNames()
     {
         $branches = $this->execute();
         $branches = \explode("\n", $branches);
         $branches = \array_map(
             function ($branch) {
-                return \ltrim($branch, '*');
+                return \trim(\ltrim($branch, '*'));
             },
             $branches
         );
-        $branches = \array_map('trim', $branches);
         $branches = \array_filter($branches);
 
-        return $branches;
+        return \array_values($branches);
     }
 }

src/Command/CheckoutCommandBuilder.php

@@ -217,12 +217,13 @@ public function patch()
      */
     public function execute($branchOrTreeIsh = null, $path = null, $_ = null)
     {
+        /** @var list<string> $paths */
+        $paths = \func_get_args();
         if ($branchOrTreeIsh) {
+            \array_shift($paths);
             $this->arguments[] = $branchOrTreeIsh;
         }
 
-        $paths = \func_get_args();
-        \array_shift($paths);
         if (\count($paths)) {
             $this->arguments[] = '--';
             foreach ($paths as $path) {

src/Command/CommitCommandBuilder.php

@@ -461,6 +461,7 @@ public function execute($pathspec = null, $_ = null)
             $this->gpgSign($this->repository->getConfig()->getSignCommitUser());
         }
 
+        /** @var list<string> $args */
         $args = \func_get_args();
         if (\count($args)) {
             $this->arguments[] = '--';
@@ -469,6 +470,6 @@ public function execute($pathspec = null, $_ = null)
             }
         }
 
-        return $this->run();
+        return (string) $this->run();
     }
 }

src/Command/DescribeCommandBuilder.php

@@ -197,6 +197,6 @@ public function firstParent()
     public function execute($commit = 'HEAD')
     {
         $this->arguments[] = $commit;
-        return $this->run();
+        return (string) $this->run();
     }
 }

src/Command/FetchCommandBuilder.php

@@ -295,12 +295,13 @@ public function execute($repository = 'origin', $refspec = null, $_ = null)
     {
         $this->arguments[] = $repository;
 
+        /** @var list<string> $refspecs */
         $refspecs = \func_get_args();
         \array_shift($refspecs);
         foreach ($refspecs as $refspec) {
             $this->arguments[] = $refspec;
         }
 
-        return $this->run();
+        return (string) $this->run();
     }
 }

src/Command/InitCommandBuilder.php

@@ -120,6 +120,6 @@ public function shared($share)
     public function execute()
     {
         $this->arguments[] = $this->repository->getRepositoryPath();
-        return $this->run();
+        return (string) $this->run();
     }
 }

src/Command/LogCommandBuilder.php

@@ -1078,13 +1078,14 @@ public function t()
      */
     public function execute($pathspec = null, $_ = null)
     {
+        /** @var list<string> $args */
         $args = \func_get_args();
         if (\count($args)) {
             $this->arguments[] = '--';
             foreach ($args as $pathspec) {
                 $this->arguments[] = $pathspec;
             }
         }
-        return $this->run();
+        return (string) $this->run();
     }
 }

src/Command/LsRemoteCommandBuilder.php

@@ -103,13 +103,14 @@ public function execute($remote, $refSpec = null, $_ = null)
     {
         $this->arguments[] = $remote;
 
+        /** @var list<string> $refSpec */
         $refSpec = \func_get_args();
         \array_shift($refSpec);
         foreach ($refSpec as $ref) {
             $this->arguments[] = $ref;
         }
 
-        return $this->run();
+        return (string) $this->run();
     }
 
     /**
@@ -129,7 +130,7 @@ public function execute($remote, $refSpec = null, $_ = null)
      */
     public function getRefs($remote, $refSpec = null, $_ = null)
     {
-        $output = \call_user_func_array([$this, 'execute'], \func_get_args());
+        $output = (string) \call_user_func_array([$this, 'execute'], \func_get_args());
         $output = \explode("\n", $output);
         $output = \array_map('trim', $output);
         $output = \array_filter($output);

src/Command/MergeCommandBuilder.php

@@ -78,12 +78,13 @@ public function strategy($strategy)
      */
     public function execute($branchOrTreeIsh = null, $path = null, $_ = null)
     {
+        /** @var list<string> $paths */
+        $paths = \func_get_args();
         if ($branchOrTreeIsh) {
+            \array_shift($paths);
             $this->arguments[] = $branchOrTreeIsh;
         }
 
-        $paths = \func_get_args();
-        \array_shift($paths);
         if (\count($paths)) {
             $this->arguments[] = '--';
             foreach ($paths as $path) {

src/Command/PullCommandBuilder.php

@@ -95,12 +95,13 @@ public function execute($repository = 'origin', $refspec = null, $_ = null)
     {
         $this->arguments[] = $repository;
 
+        /** @var list<string> $refspecs */
         $refspecs = \func_get_args();
         \array_shift($refspecs);
         foreach ($refspecs as $refspec) {
             $this->arguments[] = $refspec;
         }
 
-        return $this->run();
+        return (string) $this->run();
     }
 }

src/Command/PushCommandBuilder.php

@@ -302,12 +302,13 @@ public function execute($repository, $refspec = null, $_ = null)
     {
         $this->arguments[] = $repository;
 
+        /** @var list<string> $refspecs */
         $refspecs = \func_get_args();
         \array_shift($refspecs);
         foreach ($refspecs as $refspec) {
             $this->arguments[] = $refspec;
         }
 
-        return $this->run();
+        return (string) $this->run();
     }
 }

src/Command/RemoteCommandBuilder.php

@@ -347,7 +347,7 @@ public function update($groupOrRemote, $prune = false)
      */
     public function execute()
     {
-        return $this->run();
+        return (string) $this->run();
     }
 
     /**

src/Command/ResetCommandBuilder.php

@@ -142,10 +142,15 @@ public function commit($commit)
      */
     public function execute($path = null, $_ = null)
     {
-        $this->arguments[] = '--';
-        foreach (\func_get_args() as $path) {
-            $this->arguments[] = $path;
+        /** @var list<string> $args */
+        $args = \func_get_args();
+        if (\count($args)) {
+            $this->arguments[] = '--';
+            foreach ($args as $pathSpec) {
+                $this->arguments[] = $pathSpec;
+            }
         }
-        return $this->run();
+
+        return (string) $this->run();
     }
 }

src/Command/RevParseCommandBuilder.php

@@ -434,9 +434,11 @@ public function before($date)
      */
     public function execute($arg = null, $_ = null)
     {
-        foreach (\func_get_args() as $arg) {
+        /** @var list<string> $args */
+        $args = \func_get_args();
+        foreach ($args as $arg) {
             $this->arguments[] = $arg;
         }
-        return $this->run();
+        return (string) $this->run();
     }
 }

src/Command/RmCommandBuilder.php

@@ -118,13 +118,14 @@ public function quiet()
      */
     public function execute($pathspec = null, $_ = null)
     {
+        /** @var list<string> $args */
         $args = \func_get_args();
         if (\count($args)) {
             $this->arguments[] = '--';
             foreach ($args as $pathspec) {
                 $this->arguments[] = $pathspec;
             }
         }
-        return $this->run();
+        return (string) $this->run();
     }
 }

src/Command/ShortLogCommandBuilder.php

@@ -151,6 +151,7 @@ public function w($width, $indent1 = null, $indent2 = null)
      */
     public function execute($pathSpec = null, $_ = null)
     {
+        /** @var list<string> $args */
         $args = \func_get_args();
         if (\count($args)) {
             $this->arguments[] = '--';
@@ -159,6 +160,6 @@ public function execute($pathSpec = null, $_ = null)
             }
         }
 
-        return $this->run();
+        return (string) $this->run();
     }
 }

src/Command/ShowCommandBuilder.php

@@ -206,6 +206,6 @@ public function noPatch()
     public function execute($object)
     {
         $this->arguments[] = $object;
-        return $this->run();
+        return (string) $this->run();
     }
 }

src/Command/StatusCommandBuilder.php

@@ -198,7 +198,7 @@ public function getStatus($pathspec = null, $_ = null)
     {
         $this->porcelain();
 
-        $status = \call_user_func_array([$this, 'execute'], \func_get_args());
+        $status = (string) \call_user_func_array([$this, 'execute'], \func_get_args());
         $status = \explode("\n", $status);
 
         $files = [];
@@ -245,7 +245,7 @@ public function getIndexStatus($pathspec = null, $_ = null)
     {
         $this->porcelain();
 
-        $status = \call_user_func_array([$this, 'execute'], \func_get_args());
+        $status = (string) \call_user_func_array([$this, 'execute'], \func_get_args());
         $status = \explode("\n", $status);
 
         $files = [];
@@ -288,7 +288,7 @@ public function getWorkTreeStatus($pathspec = null, $_ = null)
     {
         $this->porcelain();
 
-        $status = \call_user_func_array([$this, 'execute'], \func_get_args());
+        $status = (string) \call_user_func_array([$this, 'execute'], \func_get_args());
         $status = \explode("\n", $status);
 
         $files = [];
@@ -321,13 +321,14 @@ public function getWorkTreeStatus($pathspec = null, $_ = null)
      */
     public function execute($pathspec = null, $_ = null)
     {
+        /** @var list<string> $args */
         $args = \func_get_args();
         if (\count($args)) {
             $this->arguments[] = '--';
             foreach ($args as $pathspec) {
                 $this->arguments[] = $pathspec;
             }
         }
-        return $this->run();
+        return (string) $this->run();
     }
 }

src/Command/TagCommandBuilder.php

@@ -276,7 +276,7 @@ public function execute($tagName = null, $commit = null)
             $this->arguments[] = $commit;
         }
 
-        return $this->run();
+        return (string) $this->run();
     }
 
     /**