Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Close deleted scripts on install. #1113

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

LJNeon
Copy link
Contributor

@LJNeon LJNeon commented Feb 20, 2024

There was some disagreement on if this fix is necessary, see the related issue for details.

fixes #1050

Copy link
Collaborator

@d0sboots d0sboots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change makes sense, but it'll need good testing because this whole area is a bunch of edge cases.

@LJNeon
Copy link
Contributor Author

LJNeon commented Feb 21, 2024

What edge cases are there? This seems like a simple enough function to me, it closes open scripts from deleted servers and updates the currently open script accordingly. The behavior has also not changed at all except for what it does on prestige (install/soft reset/backdooring wd).

EDIT: Not trying to argue this doesn't need to be tested, just not sure if it's as complicated as you said.

@d0sboots
Copy link
Collaborator

I was referring to the game itself, not so much this code. The bug this is fixing is an edge case, and there are just a variety of cases of "you do/don't have certain windows open at certain times" that should be checked. Off the top of my head, the full matrix of:

  • Script is/isn't deleted
  • Script is/isn't on home
  • Open window is/isn't the currently connected host

looked at across installs (or some other reset, they should all act the same), and also whatever it is that triggers the other codepath that calls your function

@LJNeon
Copy link
Contributor Author

LJNeon commented Feb 21, 2024

The other trigger was added by caldwell to solve a bug afaik, (nope, was remembering wrong) it runs every time the script editor tab is opened.

@LJNeon LJNeon force-pushed the installCloseScripts branch from e8d67ec to 94a60a2 Compare February 11, 2025 05:22
@d0sboots
Copy link
Collaborator

Note to possibly future self: Based on Discord history, this might be on hold pending Monaco shenanigans discovered during testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scripts on other servers can be restored after installing augments
2 participants