feat: copy shortlink micro interaction #178
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe recent updates introduce a new CSS gradient, enhance the Changes
Possibly related issues
Recent Review DetailsConfiguration used: CodeRabbit UI Files ignored due to path filters (1)
Files selected for processing (4)
Additional comments not posted (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| import { Check, CopyIcon, LoaderCircle } from 'lucide-react' | ||
| import { shorten } from '@/app/actions' | ||
| import { useAsyncFn } from 'react-use' | ||
| import { cn } from '@/lib/utils' |
There was a problem hiding this comment.
Consider grouping imports from the same module to clean up the import statements.
- import { Check, CopyIcon, LoaderCircle } from 'lucide-react'
- import { useAsyncFn } from 'react-use'
+ import { Check, CopyIcon, LoaderCircle } from 'lucide-react';
+ import { useAsyncFn } from 'react-use';Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| import { Check, CopyIcon, LoaderCircle } from 'lucide-react' | |
| import { shorten } from '@/app/actions' | |
| import { useAsyncFn } from 'react-use' | |
| import { cn } from '@/lib/utils' | |
| import { Check, CopyIcon, LoaderCircle } from 'lucide-react'; | |
| import { shorten } from '@/app/actions' | |
| import { useAsyncFn } from 'react-use'; | |
| import { cn } from '@/lib/utils' |
| const [shortlink, getShortlink] = useAsyncFn(async () => { | ||
| const formData = new FormData() | ||
| formData.set('url', url) | ||
| const { shortLink } = await shorten({}, formData) | ||
| return navigator.clipboard.writeText(shortLink).then(() => shortLink) | ||
| }) |
There was a problem hiding this comment.
Ensure proper error handling in the asynchronous function used to fetch and copy the short link.
const [shortlink, getShortlink] = useAsyncFn(async () => {
try {
const formData = new FormData();
formData.set('url', url);
const { shortLink } = await shorten({}, formData);
await navigator.clipboard.writeText(shortLink);
return shortLink;
} catch (error) {
console.error('Failed to fetch and copy shortlink:', error);
throw error; // or handle error appropriately
}
});Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| const [shortlink, getShortlink] = useAsyncFn(async () => { | |
| const formData = new FormData() | |
| formData.set('url', url) | |
| const { shortLink } = await shorten({}, formData) | |
| return navigator.clipboard.writeText(shortLink).then(() => shortLink) | |
| }) | |
| const [shortlink, getShortlink] = useAsyncFn(async () => { | |
| try { | |
| const formData = new FormData() | |
| formData.set('url', url) | |
| const { shortLink } = await shorten({}, formData) | |
| await navigator.clipboard.writeText(shortLink) | |
| return shortLink | |
| } catch (error) { | |
| console.error('Failed to fetch and copy shortlink:', error) | |
| throw error; // or handle error appropriately | |
| } | |
| }) |
| const Icon = shortlink.value | ||
| ? Check | ||
| : shortlink.loading | ||
| ? LoaderCircle | ||
| : CopyIcon | ||
|
|
||
| return ( | ||
| <Icon | ||
| className={cn( | ||
| 'pointer transition-all', | ||
| shortlink.loading && 'animate-spin' | ||
| )} | ||
| onClick={handleIconClick} | ||
| size={15} | ||
| /> |
There was a problem hiding this comment.
The dynamic icon switching logic is clear and concise. However, consider adding a tooltip or aria-label for accessibility, providing context about the icon's function.
<Icon
className={cn('pointer transition-all', shortlink.loading && 'animate-spin')}
onClick={handleIconClick}
size={15}
+ aria-label={shortlink.value ? 'Copy successful' : shortlink.loading ? 'Loading' : 'Copy link'}
/>Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| const Icon = shortlink.value | |
| ? Check | |
| : shortlink.loading | |
| ? LoaderCircle | |
| : CopyIcon | |
| return ( | |
| <Icon | |
| className={cn( | |
| 'pointer transition-all', | |
| shortlink.loading && 'animate-spin' | |
| )} | |
| onClick={handleIconClick} | |
| size={15} | |
| /> | |
| const Icon = shortlink.value | |
| ? Check | |
| : shortlink.loading | |
| ? LoaderCircle | |
| : CopyIcon | |
| return ( | |
| <Icon | |
| className={cn( | |
| 'pointer transition-all', | |
| shortlink.loading && 'animate-spin' | |
| )} | |
| onClick={handleIconClick} | |
| size={15} | |
| aria-label={shortlink.value ? 'Copy successful' : shortlink.loading ? 'Loading' : 'Copy link'} | |
| /> |
| @@ -50,7 +50,7 @@ | |||
| "framer-motion": "^10.16.12", | |||
| "geist": "^1.1.0", | |||
| "lodash": "^4.17.21", | |||
| "lucide-react": "^0.297.0", | |||
| "lucide-react": "latest", | |||
There was a problem hiding this comment.
Using the "latest" tag for lucide-react can lead to unexpected behavior if the library introduces breaking changes. Consider using a more specific version range.
- "lucide-react": "latest",
+ "lucide-react": "^current.stable.version",Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| "lucide-react": "latest", | |
| "lucide-react": "^current.stable.version", |
closes #139
Summary by CodeRabbit
New Features
Chores
lucide-reactlibrary to the latest version.