Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ARCO-295): new log level in p2p #695

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

pawellewandowski98
Copy link
Collaborator

Description of Changes

Add option to provide different log level for peers. Added TRACE level for even more descriptive logs.

Example:

blocktx-2     | Dec  6 08:30:25.096 DBG-4 Received peer.network=TestNet peer.address=node2:18333 cmd=AUTHCH
blocktx-2     | Dec  6 08:30:25.096 DBG-4 Received peer.network=TestNet peer.address=node2:18333 cmd=SENDHEADERS
blocktx-2     | Dec  6 08:30:25.096 DBG-4 Received peer.network=TestNet peer.address=node2:18333 cmd=SENDCMPCT
blocktx-2     | Dec  6 08:30:25.096 DBG-4 Received peer.network=TestNet peer.address=node2:18333 cmd=PING
blocktx-2     | Dec  6 08:30:25.096 DBG-4 Sent peer.network=TestNet peer.address=node2:18333 instance=0 cmd=PONG

NOTE: Requires #686 to be merged first

Linked Issues / Tickets

ARCO-295

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes

@pawellewandowski98 pawellewandowski98 self-assigned this Dec 6, 2024
@pawellewandowski98 pawellewandowski98 changed the base branch from main to feat-p2p-mtm December 6, 2024 08:48
@arkadiuszos4chain arkadiuszos4chain force-pushed the feature/new-log-level-in-p2p branch from 4b04371 to af7be36 Compare December 6, 2024 09:03
Copy link

sonarqubecloud bot commented Dec 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
60.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@pawellewandowski98 pawellewandowski98 merged commit 7e9ae24 into feat-p2p-mtm Dec 6, 2024
5 of 6 checks passed
@pawellewandowski98 pawellewandowski98 deleted the feature/new-log-level-in-p2p branch December 6, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants