Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(spv 1394): Separate admin and user client classes and methods #1142

Conversation

cain4chain
Copy link
Contributor

@cain4chain cain4chain commented Jan 28, 2025

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

Sorry, something went wrong.

feat(admin-api): add admin API client code
feat(user-api): add user API client code
chore(examples): update example code for admin API and user API
chore(admin-api user-api): update naming
chore(types)ClientOptions updated for user-api. Update previous ClientOptions to ClientOptionOld naming
chore(examples) Update example files and endpoints back to root folder.
fix(user-api)  update make requester types
chore(examples) update tests to xPriv versions
chore(webhook-example)  Adjust webhook example test for get webhooks
@cain4chain cain4chain added the feature Any new significant addition label Jan 28, 2025
@cain4chain cain4chain self-assigned this Jan 28, 2025
@cain4chain cain4chain requested a review from a team as a code owner January 28, 2025 04:03
Copy link

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

Copy link

github-actions bot commented Jan 28, 2025

Manual Tests

💚 Manual testing by @dzolt-4chain resulted in success.

chore(jest): update all test files
chore(webhooks): update webhooks to new admin API functions
chore(README.md): update readme documentation regarding new admin and user endpoints
…te-admin-and-user-client-classes-and-methods
feat(conflicts): update file conflicts
@dorzepowski
Copy link
Collaborator

One small tip.
To make it simpler to release new version of this library, I would suggest to change version number in package.json to the next version number in this PR.

The release of new version after merge is all about pushing a git tag with new version number, then gh actions will try to release that version for you, but if the git tag won't match version from package.json, then the release will fail.
Unfortunately we don't have the automation for changing version in package.json, so you need to do that manually. And if you won't do that in this PR, you would need to do that in a separate PR.

feat(admin-api): add AdminClientOptions for admin API
docs(readme): update docs with admin and client separation description
test(examples): update example test files with new admin api changes
chore(package.json): update beta versioning to 3.2
@dzolt-4chain dzolt-4chain added the tested PR was tested by a team member label Jan 31, 2025
chris-4chain and others added 2 commits February 3, 2025 13:49
…t-classes-and-methods
chore(examples): update test command to match example test file naming
@cain4chain cain4chain added the automerge Used for automatic merging label Feb 4, 2025
@cain4chain cain4chain merged commit 73d4fa0 into main Feb 4, 2025
6 checks passed
@cain4chain cain4chain deleted the feat(SPV-1394)-Separate-admin-and-user-client-classes-and-methods branch February 4, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used for automatic merging feature Any new significant addition tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants