BIP374: replace assert with return False in dleq_verify_proof #1962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
changed the title
jonatack
added
Proposed BIP modification
Pending acceptance
jonatack
reviewed
Sep 11, 2025
| ) -> bool: | ||
| if A.infinity or B.infinity or C.infinity or G.infinity: | ||
| return False | ||
| assert len(proof) == 64 |
There was a problem hiding this comment.
There are other places in this file with an assertion on the length; what is unique about this one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace assert with return False for proof length validation to ensure the function behaves consistently and doesn't crash when Python runs with optimization flags (-O).
This makes the validation consistent with other checks in the same function and improves robustness of the reference implementation.
Tests: All existing unit tests pass