bip155: mark torv2 as no longer in use

[brunoerg]

TorV2 is deprecated, implementations are removing any support for it and we could specify this deprecation here. Especially because implementations are no longer serializing/deserializing and relaying Tor v2 addresses, they're ignoring incoming Tor v2 addresses, etc.

[jonatack]

Pinging BIP author @laanwj for feedback or approval.

Not sure if Appendix A about Tor v2 address encoding should be removed or kept for historical context.

[jonatack]

Perhaps a Changelog would be useful here.

[brunoerg]

Not sure if Appendix A about Tor v2 address encoding should be removed or kept for historical context.

Or maybe we could keep it for historical context but change the title to Appendix A: Tor v2 address encoding (Deprecated).

[jonatack]

Maybe Appendix A: Tor v2 address encoding (for historical context, as Tor v2 is no longer operational)

[laanwj]

It doesn't look like ** works (the idea was to make bold text, i guess?) in the rendered version. https://github.com/bitcoin/bips/blob/278aa42bdca2824d0e42fbfa4a7167955b08aaf1/bip-0155.mediawiki

Also i wonder if this wouldn't better be moved to a footnote, instead of having the entire text in the table

E.g. Tor v2 hidden service address (no longer used [1])

[1] Tor v2 is no longer operational; clients MUST NOT gossip or relay Tor v2 addresses and MUST ignore them on receive

[laanwj]

Concept obvious ACK

[murchandamus]

Thanks for the review, @laanwj.
@brunoerg: I think adding a Changelog section and moving the majority of the text into a footnote sounds good.

[brunoerg]

Thanks for the review, @laanwj.
@brunoerg: I think adding a Changelog section and moving the majority of the text into a footnote sounds good.

Agreed, will do it.

[brunoerg]

Just moved the text into a footnote (I just noted that some BIPs calls the section that refers to <references/> as References and some others as Footnotes - so I think I put it on the right place) and added a Changelog.

CI failure seems unrelated:

./typos
jq: jq-1.7
$ ./typos .
Warning: "Falke" should be "False".
error: `Falke` should be `False`
    ╭▸ ./bip-0099.mediawiki:355:62
    │
355 │ Btcdrak, Gavin Andresen, Gregory Sanders, Luke Dashjr, Marco Falke.

[jonatack]

@brunoerg CI issue is indeed unrelated, fixed in #1996

[jonatack]

Agree that this information was too long for the table and is better as a footnote.

Should Appendix A also be updated with that info? Seems odd to leave it as-is and have it be contradicted elsewhere in a footnote. What do you think?

[brunoerg]

I agree it's odd to leave the Appendix A as is. We could point out there to the same <ref> we introduced before.

[brunoerg]

Done.

[murchandamus]

Looks good to me.

[murchandamus]

Actually, per BIP3 which specifies the Changelog section, the initial version should be 1.0.0. And this may well be considered a breaking change of the specification?