Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link bip-0039 #750

Closed
wants to merge 1 commit into from
Closed

Fix link bip-0039 #750

wants to merge 1 commit into from

Conversation

petterhs
Copy link

@petterhs petterhs commented Jan 3, 2019

No description provided.

@petterhs petterhs changed the title Fixed link bip-0039 Fix link bip-0039 Jan 15, 2019
@luke-jr
Copy link
Member

luke-jr commented Feb 15, 2019

@slush0 @prusnak @voisine @ebfull

murchandamus
murchandamus reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@murchandamus murchandamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link proposed in this PR leads to a 404. I’m closing this PR due to the long period of inactivity now. Please open another PR if you want to take another stab at fixing this broken link.

@katesalazar
Copy link
Contributor

I suppose the contemporary file is here[0] right now,
but for a perfect fit the fix should address an 2014-ish-contemporary permalink,
instead of a current permalink such as [0].

Do you feel like attempting that @petterhs? Or wanna leave it up for grabs?

[0]: https://github.com/libbitcoin/libbitcoin-system/blob/9b573e1737b286a6d9499babb94f0270d7862007/include/bitcoin/system/wallet/mnemonics/mnemonic.hpp

@murchandamus
Copy link
Contributor

The "Other Implementations" section was removed from the BIP per #1576.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murchandamus murchandamus murchandamus left review comments

Assignees
No one assigned
Labels
Proposed BIP modification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petterhs @luke-jr @katesalazar @murchandamus