Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync related crash on init and balance screen #15

Merged
merged 2 commits into from
Nov 11, 2020

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Nov 8, 2020

  • update build.gradle dependencies to latest versions (this is unrelated to the fix)
  • combine fragment view models into single WalletViewModel and update related fragments

Still TODO in new PRs

  1. fix crash in withdraw fragment Fix crash in withdraw fragment #16
  2. update withdraw fragement to use WalletViewModel and coroutine flows
  3. isolate root some sort of race condition related error in bdk-jni project related to sync and balance calls Possible race condition related error related to sync and balance calls bdk-jni#15
  4. remove or re-enable progress bars from balance fragment Remove or re-enable BalanceFragment progress bars #17

@notmandatory
Copy link
Member Author

I just updated the notmandatory/bdk-jni keys branch, you should update to the latest in this branch and do ./gradlew publishToMavenLocal

@lazertazer lazertazer merged commit 4cb5c3d into bitcoindevkit:master Nov 11, 2020
notmandatory pushed a commit to notmandatory/BDWallet that referenced this pull request Nov 27, 2020
Fix sync related crash on init and balance screen
notmandatory pushed a commit to notmandatory/BDWallet that referenced this pull request Nov 27, 2020
Fix sync related crash on init and balance screen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants