Move NodeEventHandler into lib.rs
#67
Merged
+29
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustaceanrob
force-pushed
the
event-10-9
branch
from
b533d1d
to
3d5e019
Compare
|
I guess you could also re-export the trait in lib.rs but this way works too. I agree with keeping the specific logger implementations in the |
|
Yeah, I just like how the rustdocs but it into a "Traits" section with the explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ValuedMammal you are as good of a judge here as I am. I am trying to make the event portion of the API more visible to users. IMO the
loggermodule makes sense for those specific implementations likePrintLogger, but I think more generally the trait might belong in the library itself.