Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LocalChain::disconnect_from method #1276

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Add LocalChain::disconnect_from method #1276

merged 1 commit into from
Jan 15, 2024

Conversation

evanlinjin
Copy link
Member

@evanlinjin evanlinjin commented Jan 15, 2024 •
edited
Loading

Closes #1271

Description

Add a method for disconnecting a chain of blocks starting from the given BlockId.

Notes to the reviewers

I want to have this for utreexo/utreexod#110

Changelog notice

Added

  • LocalChain::disconnect_from method to evict a chain of blocks starting from a given BlockId.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@evanlinjin evanlinjin added the new feature New feature or request label Jan 15, 2024
@evanlinjin evanlinjin added this to the 1.0.0 milestone Jan 15, 2024
@evanlinjin evanlinjin self-assigned this Jan 15, 2024
danielabrozzoni
danielabrozzoni approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@danielabrozzoni danielabrozzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bf67519

@danielabrozzoni danielabrozzoni merged commit 40f0765 into bitcoindevkit:master Jan 15, 2024
12 checks passed
@notmandatory notmandatory mentioned this pull request Jan 16, 2024
Closed
23 tasks
@notmandatory notmandatory mentioned this pull request Mar 18, 2024
Open
@LLFourn LLFourn mentioned this pull request Oct 29, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielabrozzoni danielabrozzoni danielabrozzoni approved these changes

@LLFourn LLFourn Awaiting requested review from LLFourn

@notmandatory notmandatory Awaiting requested review from notmandatory

Assignees

@evanlinjin evanlinjin

Labels
new feature New feature or request
Projects
BDK
Archived in project
Milestone
1.0.0-alpha
Development

Successfully merging this pull request may close these issues.

Add disconnect-block functionality for LocalChain and Wallet
2 participants
@evanlinjin @danielabrozzoni