Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pin ring to 0.17.12 for MSRV 1.63 #1876

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

evanlinjin
Copy link
Member

Description

Pin ring to 0.17.12 for MSRV.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

The latest ring version 0.17.13 changed their MSRV from 1.63 to 1.66.
The bdk_esplora client depends on ring.

ring v0.17.12
├── rustls v0.21.12
│   ├── minreq v2.13.2
│   │   ├── esplora-client v0.11.0
│   │   │   ├── bdk_esplora v0.20.1
@evanlinjin evanlinjin force-pushed the fix/ci-ring-0_17_13 branch from 3c293ef to 7d4128e Compare March 7, 2025 04:11
@evanlinjin evanlinjin marked this pull request as ready for review March 7, 2025 04:12
@evanlinjin evanlinjin added the ci label Mar 7, 2025
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7d4128e

@evanlinjin evanlinjin merged commit e922efe into bitcoindevkit:master Mar 7, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants