Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PSBT output's unknownKeyVals #33

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Fix PSBT output's unknownKeyVals #33

merged 1 commit into from
Aug 26, 2023

Conversation

summraznboi
Copy link
Contributor

Typo fixed where adding output was placing the specified unknownKeyVals into the input of the corresponding outputIndex instead.

@summraznboi
Fix PSBT output's unknownKeyVals
2cc726a 
Typo fixed where adding output was placing the specified unknownKeyVals into the input of the corresponding outputIndex instead.
@summraznboi
Copy link
Contributor Author

@junderw just tagging you since there is not much recent activity in this repo.

junderw
junderw approved these changes Aug 26, 2023
View reviewed changes
Copy link
Member

@junderw junderw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Audit check failure was transitive deps for nyc and tslint, so they don't affect the actual package itself.

LGTM

@junderw junderw merged commit fc4aab5 into bitcoinjs:master Aug 26, 2023
5 of 6 checks passed
@junderw
Copy link
Member

junderw commented Aug 26, 2023

Published as v2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junderw junderw junderw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@summraznboi @junderw