-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: groundwork for grid size #2499
Conversation
# Conflicts: # lib/Surface/Handler.js # lib/Surface/IP/Satellite.js
# Conflicts: # lib/Surface/Handler.js # lib/Surface/USB/LoupedeckCt.js
|
The Loupedeck CT is working now with one exception: when a button gets redrawn, it will only update buttons on the upper half and the first button on the lower half. On page change, everything is drawn correctly. I've seen that the location row and column sometimes is a number and sometimes is a string. Maybe that's the problem. |
Thanks for fixing up the CT implementation
Yeah, Im not surprised. This is an issue we already have with the page & bank. Sounds solvable, but they could come from anywhere...
Yeah, I dont feel strongly that it shouldnt change. Trying to avoid doing too much at once, so now that the way I was handling 'locations' has changed, I think this can be tackled. Im not sure if it should change when they are two parameters in the code (still referred to as x&y), or just in user facing places? |
Ok, the number fix also fixed some of the CT problems (=== comparisons now work).
I think row,column will be definitely better. Internal xy-stuff can be left xy, but I have allready found off by one errors. |
ok, I have swapped them everywhere that I think needs it. Other than some additional testing, I think this is back to being ready |
My only concern at the moment is, that everytime I switch back from this branch, Companion won't start because of a too new database. I thought it would just ignore newer database formats and work with the old one. |
That will happen going between this and develop, but it doesn't happen between this and beta |
This lays the groundwork for being able to change the grid size, with the following key changes:
bank:<uuid>
instead ofbank:<page>:<bank>
bank
number, that has been replaced with a coordinate string (eg 0x0)bank
numberThis is a very sprawling change, and it is likely to have broken things in the process.
With this change, there should be no technical reason for being limited to 8x4.
All of the protocols (including cloud) are still using the old bank numbers, further changes will be needed to allow for clients to use coordinates instead.