Skip to content

Commit

Permalink
Remove explicit --namespace from example ksonnet-seal usage
Browse files Browse the repository at this point in the history
Remove explicit `--namespace` from `ksonnet-seal` example usage for
consistency with nearby `kubectl` command.

Add a better description of the precise mechanisms used to determine
output sealedsecret namespace.

[ci skip]
  • Loading branch information
anguslees committed Jun 21, 2017
1 parent 6d1dc87 commit db807eb
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ use the Makefile:

```sh
# This is the important bit:
$ ksonnet-seal --namespace default <mysecret.json >mysealedsecret.json
$ ksonnet-seal <mysecret.json >mysealedsecret.json

# mysealedsecret.json is safe to upload to github, post to twitter,
# etc. Eventually:
Expand All @@ -83,9 +83,11 @@ $ kubectl get secret mysecret

Note the `SealedSecret` and `Secret` must have *the same namespace and
name*. This is a feature to prevent other users on the same cluster
from re-using your sealed secrets. Any labels, annotations, etc on
the original `Secret` are preserved, but not automatically reflected
in the `SealedSecret`.
from re-using your sealed secrets. `ksonnet-seal` reads the namespace
from the input secret, accepts an explicit `--namespace` arg, and uses
the `kubectl` default namespace (in that order). Any labels,
annotations, etc on the original `Secret` are preserved, but not
automatically reflected in the `SealedSecret`.

By design, this scheme *does not authenticate the user*. In other
words, *anyone* can create a `SealedSecret` containing any `Secret`
Expand Down

0 comments on commit db807eb

Please sign in to comment.