Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add particular use case to the modifiers docs #65

Merged
merged 3 commits into from
Jul 31, 2023

Conversation

kuisathaverat
Copy link
Contributor

Description of the change

It adds a particular case to the modifiers documentation I hit using custom modifiers.
The use case is when you do not give any value to the parameter and use a custom modifier.
Also, it adds the name of the parameter that hits the error when an error related to modifiers happens.

Benefits

Users will not spend time trying to resolve the issue, it is documented.

Possible drawbacks

none

lib/builder.js Outdated Show resolved Hide resolved
Copy link
Contributor

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kuisathaverat and @revolunet for your contribution. LGTM

@fmulero fmulero merged commit eab1e71 into bitnami:main Jul 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants