Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

218 react virtual dom #221

Merged
merged 3 commits into from
Dec 29, 2020
Merged

218 react virtual dom #221

merged 3 commits into from
Dec 29, 2020

Conversation

NCharby
Copy link

@NCharby NCharby commented Dec 29, 2020 •
edited
Loading

@NCharby NCharby requested a review from dcrescim December 29, 2020 20:39
@NCharby NCharby self-assigned this Dec 29, 2020
@NCharby NCharby mentioned this pull request Dec 29, 2020
Open
@EmilK15
Copy link
Contributor

EmilK15 commented Dec 29, 2020

looks like you used yarn instead of npm so it generated a yarn.lock file. If you can remove it the rest lgtm

@NCharby NCharby merged commit d19bc46 into master Dec 29, 2020
@NCharby NCharby deleted the 218_react_virtua_dom branch December 29, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcrescim dcrescim Awaiting requested review from dcrescim

Assignees

@NCharby NCharby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NCharby @EmilK15