Draft: [ACI-4171] share code with sim build step #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will support build-for-simulator code sharing
SummaryThis PR adds support for simulator platforms by defining new internal platform types (iOS Simulator, watchOS Simulator, tvOS Simulator) and implementing logic to skip IPA export for platforms that don't support it. The changes enable the build-for-simulator step to share code with the archive step. Walkthrough
|
Badlazzor
changed the title
| case strings.HasPrefix(sdk, "appletvsimulator"): | ||
| return tvOSSimulator, nil | ||
| default: | ||
| return "", fmt.Errorf("unkown SDKROOT: %s", sdk) |
There was a problem hiding this comment.
🐛 Bug
Typo in error message: "unkown" should be "unknown"
🔄 Suggestion:
Suggested change
| return "", fmt.Errorf("unkown SDKROOT: %s", sdk) | |
| return "", fmt.Errorf("unknown SDKROOT: %s", sdk) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define new internal platform types so that the build-for-simulator step can use archive as the primary codebase for delivering its artifacts