Skip to content

Conversation

yao-matrix
Copy link

in to only data of param moved to the specified device, but SCB and CB still keep in the before device, this will lead to peft below ut fail

pytest -rA tests/test_gpu_examples.py::TestLoftQ::test_bloomz_loftq_8bit[cpu]

Since in this code https://github.com/huggingface/peft/blob/main/src/peft/utils/integrations.py#L107, peft will find weight.data has different placement from SCB, so kind of only partial to was done.

Signed-off-by: Yao, Matrix <matrix.yao@intel.com>
@yao-matrix
Copy link
Author

@matthewdouglas @jiqing-feng , pls help review and comment, thx very much.

@matthewdouglas matthewdouglas added Hugging Face Integration An issue or PR that is related to the interaction between bitsandbytes and HF libraries. Cross Platform labels Sep 26, 2025
@matthewdouglas matthewdouglas added this to the v0.48.0 milestone Sep 26, 2025
@matthewdouglas
Copy link
Member

Makes sense, thanks! Let's just fix the lint issue and we can merge it.

Related issue: #1332

matthewdouglas
matthewdouglas previously approved these changes Sep 26, 2025
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Signed-off-by: Yao, Matrix <matrix.yao@intel.com>
@yao-matrix
Copy link
Author

@matthewdouglas , fixed lint, thx very much.

@matthewdouglas
Copy link
Member

Thanks @yao-matrix. I've taken this a little bit further in #1769 and will merge that instead.

@yao-matrix yao-matrix deleted the bug-fix branch September 30, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross Platform Hugging Face Integration An issue or PR that is related to the interaction between bitsandbytes and HF libraries.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants