fix for the missed_blocks being too big, set to zero. v3 #2825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to be a witness, and loading custom genesis where initial_timestamp is far behind, there seems to be an C++ UB
in
dgp.recent_slots_filled = ... << missed_blocksin https://github.com/bitshares/bitshares-core/blob/develop/libraries/chain/db_update.cpp#L68
because we left-shift by more than 126 (or 127, 128) bits there
https://timsong-cpp.github.io/cppwp/n4140/expr.shift#1 for C++14.
In this version, we set
dgp.recent_slots_filledmanually to the expected value0instead trying to use operator<< for this corner case.We also print error log (and once print the longer explanation of problem).