Skip to content

Solving race condition when context times out. #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
girino wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solving race condition when context times out. #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions wot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ func refreshTrustNetwork() {
log.Println("🌐 building web of trust graph")
nPubkeys := uint(0)
for i := 0; i < len(oneHopNetwork); i += 100 {
timeoutCtx, cancel = context.WithTimeout(ctx, timeout)
done := make(chan struct{})

end := i + 100
if end > len(oneHopNetwork) {
end = len(oneHopNetwork)
Expand All @@ -53,7 +50,12 @@ func refreshTrustNetwork() {
Kinds: []int{nostr.KindFollowList, nostr.KindRelayListMetadata},
}

go func() {
// this does not need to be a goroutine, since we
// were waiting for "done" before moving to the next batch
// making it syncronous ends the race condition with pubkeyFollowerCount
func() {
// make sure the timeout is not already cancelled
timeoutCtx, cancel = context.WithTimeout(ctx, timeout)
defer cancel()

events := pool.FetchMany(timeoutCtx, config.ImportSeedRelays, filter)
Expand All @@ -69,15 +71,9 @@ func refreshTrustNetwork() {
appendRelay(relay[1])
}
}
close(done)
}()

select {
case <-done:
log.Println("🕸️ analysed", nPubkeys, "followed pubkeys so far")
case <-timeoutCtx.Done():
log.Println("🚫Timeout while fetching pubkeys, moving to the next batch")
}
log.Println("🕸️ analysed", nPubkeys, "followed pubkeys so far")
}
log.Println("🫂 total network size:", len(pubkeyFollowerCount))
log.Println("🔗 relays discovered:", len(wotRelays))
Expand Down