Ensure complex protobuf files can be parsed #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bitwalker could you have a look and tell me what you think? the changes are small but important for my team |
|
@bitwalker Paul, any chance to get that into master? |
|
@bitwalker could you review this? |
|
@bitwalker one test file was missing, now The CI is working. Could you review? |
|
@bitwalker any update on this or help we can provide? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
:reserved_numberstoken fromgpbwas not supported and prevented a Google protobuf file to be read (even though it worked on one of my fork but I cannot identify the cause).This PR fixes the problem.