Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17724] Allow vault search to include ports in URI matching #13136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

calebvisage
Copy link

🎟️ Tracking

Solves issue #13134

📔 Objective

The search indexer strips out port numbers from the login item URIs, thus not allowing the user to search the vault for an item with a URI that contains a port number. e.g. the user wants to find item with uri 192.168.1.2:8000. the user searches for ":8000" but finds no results, because the uri has been stripped to 192.168.1.2 by uriExtractor.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@CLAassistant
Copy link

CLAassistant commented Jan 29, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-17724
Link: https://bitwarden.atlassian.net/browse/PM-17724

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@bitwarden-bot bitwarden-bot changed the title Fix vault search for port on URI [PM-17724] Fix vault search for port on URI Jan 29, 2025
@djsmith85 djsmith85 linked an issue Jan 29, 2025 that may be closed by this pull request
1 task
@calebvisage calebvisage changed the title [PM-17724] Fix vault search for port on URI [PM-17724] Allow vault search to include ports in URI matching Jan 30, 2025
@kyletitus-lula
Copy link

@Jingo88 can someone have a look at this? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow vault search to include ports in URI matching
4 participants