Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce desktop disk writes #13271

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

tangowithfoxtrot
Copy link
Contributor

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.76%. Comparing base (2284fe3) to head (2b540f4).
Report is 6 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (2284fe3) and HEAD (2b540f4). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (2284fe3) HEAD (2b540f4)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #13271       +/-   ##
===========================================
- Coverage   35.29%   15.76%   -19.53%     
===========================================
  Files        3124       27     -3097     
  Lines       92483     1884    -90599     
  Branches    16818        0    -16818     
===========================================
- Hits        32638      297    -32341     
+ Misses      57388     1587    -55801     
+ Partials     2457        0     -2457     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Logo
Checkmarx One – Scan Summary & Detailsf6c8a6ad-5a60-481a-8fed-67eb0ab64957

New Issues (3)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
LOW HttpOnly_Cookie_Flag_Not_Set /apps/web/src/app/auth/core/services/login/web-sso-component.service.ts: 19
detailsThe web application's setDocumentCookies method creates a cookie cookie, at line 19 of /apps/web/src/app/auth/core/services/login/web-sso-component...
Attack Vector
LOW HttpOnly_Cookie_Flag_Not_Set /apps/web/src/app/auth/sso-v1.component.ts: 175
detailsThe web application's Lambda method creates a cookie cookie, at line 175 of /apps/web/src/app/auth/sso-v1.component.ts, and returns it in the respo...
Attack Vector
LOW HttpOnly_Cookie_Flag_Not_Set /apps/web/src/connectors/sso.ts: 37
detailsThe web application's initiateBrowserSso method creates a cookie cookie, at line 37 of /apps/web/src/connectors/sso.ts, and returns it in the respo...
Attack Vector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant