Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-18218] CLI: SSO improvements #13356

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

frq-asgard-josi
Copy link

@frq-asgard-josi frq-asgard-josi commented Feb 11, 2025

🎟️ Tracking

Summary

This PR introduces two improvements to the CLI client:

  • The SSO-Prompt URL is printed as console output.
    • This enables the usage of SSO in scenarios where opening a browser doesn't work (such as in containers and ssh sessions, including devcontainers, port forwarding for the callback-url is usually not an issue in these cases).
  • The --sso parameter now takes an optional [sso-identifier] argument, allowing the user to skip the SSO-Identifier input prompt.

📔 Objective

  • Enable usage of the CLI in containerized applications (such as devcontainers) where 'platformUtilsService.launchUri' doesn't work.
  • Reduce user interaction overhead due to SSO-Identifier input prompt, even if only one SSO-Provider is configured.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
    - [ ] Used internationalization (i18n) for all UI strings (Doesn't apply)
  • CI builds passed
    - [ ] Communicated to DevOps any deployment requirements (Doesn't apply)
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-18218
Link: https://bitwarden.atlassian.net/browse/PM-18218

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@bitwarden-bot bitwarden-bot changed the title CLI: SSO improvements [PM-18218] CLI: SSO improvements Feb 11, 2025
@frq-asgard-josi frq-asgard-josi marked this pull request as ready for review February 11, 2025 15:14
@frq-asgard-josi frq-asgard-josi requested a review from a team as a code owner February 11, 2025 15:14
@Patrick-Pimentel-Bitwarden
Copy link
Contributor

Hey there, thank you for your contribution. If you wouldn't mind signing the Contributor License Agreement then I can move forward with the process of getting this QA'd and merged!

@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden added the needs-qa Marks a PR as requiring QA approval label Feb 13, 2025
@frq-asgard-josi
Copy link
Author

Hey there, thank you for your contribution. If you wouldn't mind signing the Contributor License Agreement then I can move forward with the process of getting this QA'd and merged!

Im just waiting on approval from my supervisor to sign the CLA. It might take a few days until I get Feedback for that but I am working on it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-pr needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants