-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add learnMoreAboutBlockedDomains translation key and append to desc. #13358
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13358 +/- ##
==========================================
+ Coverage 35.20% 35.29% +0.08%
==========================================
Files 3126 3124 -2
Lines 92567 92345 -222
Branches 16857 16791 -66
==========================================
+ Hits 32590 32593 +3
+ Misses 57520 57295 -225
Partials 2457 2457 ☔ View full report in Codecov by Sentry. |
Great job, no security vulnerabilities found in this Pull Request |
apps/browser/src/autofill/popup/settings/blocked-domains.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tweak to get the link working
…nent.html Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>
🎟️ Tracking
PM-15997
📔 Objective
Adds learn more link to blocked domains description.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes