Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add learnMoreAboutBlockedDomains translation key and append to desc. #13358

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

blackwood
Copy link

@blackwood blackwood commented Feb 11, 2025

🎟️ Tracking

PM-15997

📔 Objective

Adds learn more link to blocked domains description.

📸 Screenshots

Screenshot 2025-02-11 at 11 17 23 AM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@blackwood blackwood requested a review from a team as a code owner February 11, 2025 16:17
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.29%. Comparing base (4cb8e85) to head (df05e05).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13358      +/-   ##
==========================================
+ Coverage   35.20%   35.29%   +0.08%     
==========================================
  Files        3126     3124       -2     
  Lines       92567    92345     -222     
  Branches    16857    16791      -66     
==========================================
+ Hits        32590    32593       +3     
+ Misses      57520    57295     -225     
  Partials     2457     2457              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Logo
Checkmarx One – Scan Summary & Detailsadc8817e-e7b0-45f4-b10d-97bab40215de

Great job, no security vulnerabilities found in this Pull Request

@jprusik jprusik self-requested a review February 11, 2025 17:32
Copy link
Contributor

@jprusik jprusik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tweak to get the link working

…nent.html

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>
jprusik
jprusik previously approved these changes Feb 11, 2025
@blackwood blackwood added the needs-qa Marks a PR as requiring QA approval label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants