Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-18215 Create UI for confirmation notification message #13364

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dan-livefront
Copy link
Collaborator

@dan-livefront dan-livefront commented Feb 11, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-18215

📔 Objective

Created NotificationConfirmationBody to render appropriate confirmation message with an icon. It displays PartyHorn by default or Warning ( new svg icon ) if error is present. The component only renders if both buttonText and confirmationMessage are passed into it.

Note: The warning SVG as of now has the same svg for both light and dark mode due to the figma file not having a dark mode svg.

📸 Screenshots

Screenshot 2025-02-11 at 3 38 25 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 35.28%. Comparing base (5f2a773) to head (6d506a7).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...ll/content/components/notification/confirmation.ts 0.00% 16 Missing ⚠️
...nt/components/notification/confirmation-message.ts 0.00% 8 Missing ⚠️
...r/src/autofill/content/components/icons/warning.ts 0.00% 6 Missing ⚠️
...t-stories/notification/confirmation.lit-stories.ts 0.00% 5 Missing ⚠️
...ser/src/autofill/content/components/icons/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13364      +/-   ##
==========================================
- Coverage   35.29%   35.28%   -0.02%     
==========================================
  Files        3124     3128       +4     
  Lines       92349    92526     +177     
  Branches    16793    16825      +32     
==========================================
+ Hits        32593    32646      +53     
- Misses      57299    57422     +123     
- Partials     2457     2458       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Logo
Checkmarx One – Scan Summary & Details5e0910cc-d593-43f0-ba2a-1c556a4d56ed

Fixed Issues (3)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
LOW Client_JQuery_Deprecated_Symbols /apps/web/src/app/tools/reports/pages/weak-passwords-report.component.ts: 94
LOW Client_JQuery_Deprecated_Symbols /apps/web/src/app/tools/reports/pages/weak-passwords-report.component.ts: 87
LOW Client_JQuery_Deprecated_Symbols /apps/browser/src/autofill/background/overlay.background.ts: 756

@dan-livefront dan-livefront marked this pull request as ready for review February 13, 2025 15:22
@dan-livefront dan-livefront requested a review from a team as a code owner February 13, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant