-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-18215 Create UI for confirmation notification message #13364
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13364 +/- ##
==========================================
- Coverage 35.29% 35.28% -0.02%
==========================================
Files 3124 3128 +4
Lines 92349 92526 +177
Branches 16793 16825 +32
==========================================
+ Hits 32593 32646 +53
- Misses 57299 57422 +123
- Partials 2457 2458 +1 ☔ View full report in Codecov by Sentry. |
Fixed Issues (3)Great job! The following issues were fixed in this Pull Request
|
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-18215
📔 Objective
Created
NotificationConfirmationBody
to render appropriate confirmation message with an icon. It displaysPartyHorn
by default orWarning
( new svg icon ) if error is present. The component only renders if bothbuttonText
andconfirmationMessage
are passed into it.Note: The warning SVG as of now has the same svg for both light and dark mode due to the figma file not having a dark mode svg.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes