-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROTOTYPE] LogSubject
with ECS log format
#13367
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13367 +/- ##
===========================================
- Coverage 35.20% 15.76% -19.45%
===========================================
Files 3126 27 -3099
Lines 92563 1884 -90679
Branches 16857 0 -16857
===========================================
- Hits 32590 297 -32293
+ Misses 57516 1587 -55929
+ Partials 2457 0 -2457 ☔ View full report in Codecov by Sentry. |
Great job, no security vulnerabilities found in this Pull Request |
🛑 This PR is created to share ideas; it will not be merged.
📔 Objective
This code outlines an imagined
LogSubject
, which operates like a persistentReplaySubject
.UserStateSubject
to outline the contours of the type.❗ Note ❗
The elastic common schema was used because I'm familiar with it. The schema for a full implementation is an open decision.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes