-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-18039] Add initial verison of IpcServices to client #13373
base: main
Are you sure you want to change the base?
[PM-18039] Add initial verison of IpcServices to client #13373
Conversation
The code was making some wrong assumptions about how IPC is going to work. I'm removing everything and starting the content-script instead
…pc-services-on-clients
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13373 +/- ##
===========================================
- Coverage 35.28% 15.76% -19.53%
===========================================
Files 3124 27 -3097
Lines 92349 1884 -90465
Branches 16793 0 -16793
===========================================
- Hits 32586 297 -32289
+ Misses 57306 1587 -55719
+ Partials 2457 0 -2457 ☔ View full report in Codecov by Sentry. |
New Issues (4)Checkmarx found the following issues in this Pull Request
Fixed Issues (3)Great job! The following issues were fixed in this Pull Request
|
|
🎟️ Tracking
📔 Objective
Depends on bitwarden/sdk-internal#161
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes