Add cdk-visually-hidden to tw-theme for Angular CDK LiveAnnouncer #13410
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13410 +/- ##
==========================================
- Coverage 35.33% 35.29% -0.04%
==========================================
Files 3130 3126 -4
Lines 92593 92597 +4
Branches 16810 16805 -5
==========================================
- Hits 32719 32684 -35
- Misses 57433 57473 +40
+ Partials 2441 2440 -1 ☔ View full report in Codecov by Sentry. |
|
Great job, no security vulnerabilities found in this Pull Request |
There was a problem hiding this comment.
Did you find this documented somewhere? Does the CDK have a style sheet they expect us to import? Wondering if we might be missing any other styles.
edit: ah, found here https://material.angular.io/cdk/a11y/overview#hiding-elements-in-an-accessible-way
|
|
I changed to importing the CDK css. In case they ever update it. |
|
Possibly related #13471 |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17207
📔 Objective
Angular CKD LiveAnnouncer depends on some css logic to hide announcements from being displayed. We are currently missing this functionality as we don't import CDK styles globally.
Resolves #13260
Resolves #13471
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes