-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-17232] Move all desktop native dependencies to workspace Cargo.toml #13750
base: main
Are you sure you want to change the base?
Conversation
New Issues (6)Checkmarx found the following issues in this Pull Request
Fixed Issues (19)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #13750 +/- ##
==========================================
- Coverage 36.02% 36.01% -0.01%
==========================================
Files 3175 3175
Lines 93374 93374
Branches 16962 16962
==========================================
- Hits 33635 33628 -7
- Misses 57151 57158 +7
Partials 2588 2588 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17232
📔 Objective
We currently have direct dependencies listed in our
Cargo.toml
files for each of the subcrates indesktop-native
. In order to allow dependency updates to be reviewed by the dependency-owning team, not necessarily the subcrate-owning team, we have decided to move alldesktop_native
dependencies into the workspaceCargo.toml
.This will allow us to manage dependency ownership directly in
renovate.json5
instead of relying onCODEOWNERS
to assign reviewers for dependency updates.This PR assigns the Rust dependencies based on my best interpretation of who the correct code owner should be. This change adds Renovate-managed dependencies for the following teams, so I made sure they are included in this PR:
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes