[PM-18669] - Moving item to org in desktop app does not update until sync

[jaasen-livefront]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-18669

📔 Objective

This PR fixes an issue where after moving an item to an org the vault list was not updating. While working on this issue I discovered a bug where the list wasn't updating after saving an item which is why there includes a change to savedCipher.

📸 Screenshots

Before

Screen.Recording.2025-03-07.at.5.32.24.PM.mov

After

Screen.Recording.2025-03-10.at.11.27.47.AM.mov

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 35.91%. Comparing base (895b36a) to head (6ae7cea).
Report is 40 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...pps/desktop/src/vault/app/vault/vault.component.ts	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13754      +/-   ##
==========================================
- Coverage   36.02%   35.91%   -0.11%     
==========================================
  Files        3175     3181       +6     
  Lines       93374    93335      -39     
  Branches    16962    17013      +51     
==========================================
- Hits        33635    33523     -112     
- Misses      57151    57213      +62     
- Partials     2588     2599      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Checkmarx One – Scan Summary & Details – 6367bd26-1b63-42a6-9983-709fb8ac64a7

Great job, no security vulnerabilities found in this Pull Request

[Kamika007z]

Thank you @jaasen-livefront for reporting this and providing a thorough example of it.

One question:

For the “After” video, on the second half of it, I didn’t see the username change on the right “Item Information” side, but only on the left list side.

Was this intentional? This was one of the issues that we had come across in the earlier thread, which was just fixed in the last PR; so I wanted to make sure there weren’t any regression when this proposed fix is merged into the current 2025.2.1 build.

Thanks again.

[jaasen-livefront]

Thank you @jaasen-livefront for reporting this and providing a thorough example of it.

One question:

For the “After” video, on the second half of it, I didn’t see the username change on the right “Item Information” side, but only on the left list side.

Was this intentional? This was one of the issues issues that we had come across in the earlier thread, which was just fixed in the last PR; so I wanted to make sure there weren’t any regression when this proposed fix is merged into the current 2025.2.1 build.

Thanks again.

@Kamika007z Thanks for pointing this out!

You're absolutely correct, the cipher view was not properly updating. I've included a fix for this and uploaded a new screen recording capturing the fix.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud