Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-18576] Fix missing user id on remove password #13777

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

mzieniukbw
Copy link
Contributor

@mzieniukbw mzieniukbw commented Mar 10, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-18576

📔 Objective

  • Remove Master Password page does not load, due to missing userId error.
  • Refactor of the remove-password base component.
  • Key connector service requires explicit user id.
  • Increased test coverage

📸 Screenshots

2025-03-11.00-03-34.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.04%. Comparing base (85a5aea) to head (d7c8533).
Report is 18 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...r/src/auth/components/remove-password.component.ts 96.42% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13777      +/-   ##
==========================================
+ Coverage   36.01%   36.04%   +0.03%     
==========================================
  Files        3174     3179       +5     
  Lines       93357    93230     -127     
  Branches    16960    16993      +33     
==========================================
- Hits        33623    33609      -14     
+ Misses      57144    57016     -128     
- Partials     2590     2605      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Mar 11, 2025

Logo
Checkmarx One – Scan Summary & Details4c18e148-043c-4962-9e72-166a53ce3334

Great job, no security vulnerabilities found in this Pull Request

@mzieniukbw mzieniukbw requested a review from a team March 11, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants