[PM-18993] Opaque enrollment #13782
Draft
[PM-18993] Opaque enrollment #13782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## innovation/opaque #13782 +/- ##
======================================================
- Coverage 35.96% 6.00% -29.97%
======================================================
Files 3177 27 -3150
Lines 93153 1665 -91488
Branches 16975 0 -16975
======================================================
- Hits 33506 100 -33406
+ Misses 57050 1565 -55485
+ Partials 2597 0 -2597 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
New Issues (66)Checkmarx found the following issues in this Pull Request
|
eliykat
commented
Mar 11, 2025
Comment on lines
+9
to
+13
| /** | ||
| * Authenticate using the Opaque login method. | ||
| * @returns The UserKey obtained during the Opaque login flow. | ||
| */ | ||
| abstract Login(masterPassword: string): Promise<UserKey>; |
There was a problem hiding this comment.
This could be called from a new OpaqueLoginStrategy, so that the strategy itself can focus on the high level process and bootstrapping the environment, without needing to know about the opaque implementation.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-18993
📔 Objective
Add client-side support for opaque enrollment.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes