Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anders/passkey window working mergetest #13784

Draft
wants to merge 88 commits into
base: main
Choose a base branch
from

Conversation

abergs
Copy link
Member

@abergs abergs commented Mar 11, 2025

  • Passkey stuff
  • Ugly hacks
  • Work On Modal State Management
  • Applying modalStyles
  • modal
  • Improved hide/show
  • fixed promise
  • File name
  • fix prettier
  • Protecting against null API's and undefined data
  • Only show fake popup to devs
  • cleanup mock code
  • rename minmimal-app to modal-app
  • Added comment
  • Added comment
  • removed old comment
  • Avoided changing minimum size
  • Add small comment
  • Rename component
  • adress feedback
  • Fixed uppercase file
  • Fixed build
  • Added codeowners
  • added void
  • commentary
  • feat: reset setting on app start
  • Moved reset to be in main / process launch
  • Add comment to create window
  • Added a little bit of styling
  • Use Messaging service to loadUrl
  • Enable passkeysautofill
  • Add logging
  • halfbaked
  • Integration working
  • And now it works without extra delay
  • Clean up
  • add note about messaging
  • lb
  • removed console.logs
  • Cleanup and adress review feedback
  • This hides the swift UI
  • pick credential, draft
  • Remove logger
  • a whole lot of wiring
  • not working
  • Improved wiring
  • Cancel after 90s
  • Introduced observable
  • Launching bitwarden if its not running
  • Passing position from native to electron
  • Rename inModalMode to modalMode
  • remove tap
  • revert spaces
  • added back isDev
  • cleaned up a bit
  • Cleanup swift file
  • tweaked logging
  • clean up
  • Update apps/desktop/macos/autofill-extension/CredentialProviderViewController.swift
  • Update apps/desktop/src/platform/main/autofill/native-autofill.main.ts
  • Update apps/desktop/src/platform/services/desktop-settings.service.ts
  • adress position feedback
  • Update apps/desktop/macos/autofill-extension/CredentialProviderViewController.swift
  • Removed extra logging
  • Adjusted error logging
  • Use .error to log errors
  • remove dead code
  • Update desktop-autofill.service.ts
  • use parseCredentialId instead of guidToRawFormat
  • Update apps/desktop/src/autofill/services/desktop-autofill.service.ts
  • Change windowXy to a Record instead of [number,number]
  • Update apps/desktop/src/autofill/services/desktop-fido2-user-interface.service.ts
  • Remove unsued dep and comment
  • changed timeout to be spec recommended maxium, 10 minutes, for now.
  • Correctly assume UP
  • Removed extra cancelRequest in deinint
  • Add timeout and UV to confirmChoseCipher
  • Improved docs regarding undefined cipherId
  • cleanup: UP is no longer undefined
  • Run completeError if ipc messages conversion failed
  • don't throw, instead return undefined
  • Disabled passkey provider
  • Throw error if no activeUserId was found
  • removed comment

abergs and others added 27 commits February 27, 2025 19:57
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
…ntroller.swift

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
…e.service.ts

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
UV is performed by UI, not the service
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 1.50754% with 196 lines in your changes missing coverage. Please review.

Project coverage is 35.88%. Comparing base (7e6f2fa) to head (8a575f4).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...l/services/desktop-fido2-user-interface.service.ts 0.00% 53 Missing ⚠️
.../src/autofill/services/desktop-autofill.service.ts 0.00% 35 Missing ⚠️
apps/desktop/desktop_native/napi/src/lib.rs 0.00% 26 Missing ⚠️
...p/src/app/components/fido2placeholder.component.ts 0.00% 23 Missing ⚠️
apps/desktop/src/main/window.main.ts 0.00% 15 Missing ⚠️
...s/desktop/desktop_native/macos_provider/src/lib.rs 0.00% 8 Missing ⚠️
...src/platform/main/autofill/native-autofill.main.ts 0.00% 8 Missing ⚠️
apps/desktop/src/platform/popup-modal-styles.ts 0.00% 8 Missing ⚠️
apps/desktop/src/autofill/preload.ts 0.00% 7 Missing ⚠️
.../src/platform/services/desktop-settings.service.ts 33.33% 4 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13784      +/-   ##
==========================================
- Coverage   35.93%   35.88%   -0.06%     
==========================================
  Files        3179     3179              
  Lines       93222    93361     +139     
  Branches    16989    16999      +10     
==========================================
+ Hits        33502    33503       +1     
- Misses      57123    57261     +138     
  Partials     2597     2597              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsb5778dad-893c-4e82-9032-95cd15772658

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants