-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
anders/passkey window working mergetest #13784
base: main
Are you sure you want to change the base?
Conversation
abergs
commented
Mar 11, 2025
- Passkey stuff
- Ugly hacks
- Work On Modal State Management
- Applying modalStyles
- modal
- Improved hide/show
- fixed promise
- File name
- fix prettier
- Protecting against null API's and undefined data
- Only show fake popup to devs
- cleanup mock code
- rename minmimal-app to modal-app
- Added comment
- Added comment
- removed old comment
- Avoided changing minimum size
- Add small comment
- Rename component
- adress feedback
- Fixed uppercase file
- Fixed build
- Added codeowners
- added void
- commentary
- feat: reset setting on app start
- Moved reset to be in main / process launch
- Add comment to create window
- Added a little bit of styling
- Use Messaging service to loadUrl
- Enable passkeysautofill
- Add logging
- halfbaked
- Integration working
- And now it works without extra delay
- Clean up
- add note about messaging
- lb
- removed console.logs
- Cleanup and adress review feedback
- This hides the swift UI
- pick credential, draft
- Remove logger
- a whole lot of wiring
- not working
- Improved wiring
- Cancel after 90s
- Introduced observable
- Launching bitwarden if its not running
- Passing position from native to electron
- Rename inModalMode to modalMode
- remove tap
- revert spaces
- added back isDev
- cleaned up a bit
- Cleanup swift file
- tweaked logging
- clean up
- Update apps/desktop/macos/autofill-extension/CredentialProviderViewController.swift
- Update apps/desktop/src/platform/main/autofill/native-autofill.main.ts
- Update apps/desktop/src/platform/services/desktop-settings.service.ts
- adress position feedback
- Update apps/desktop/macos/autofill-extension/CredentialProviderViewController.swift
- Removed extra logging
- Adjusted error logging
- Use .error to log errors
- remove dead code
- Update desktop-autofill.service.ts
- use parseCredentialId instead of guidToRawFormat
- Update apps/desktop/src/autofill/services/desktop-autofill.service.ts
- Change windowXy to a Record instead of [number,number]
- Update apps/desktop/src/autofill/services/desktop-fido2-user-interface.service.ts
- Remove unsued dep and comment
- changed timeout to be spec recommended maxium, 10 minutes, for now.
- Correctly assume UP
- Removed extra cancelRequest in deinint
- Add timeout and UV to confirmChoseCipher
- Improved docs regarding undefined cipherId
- cleanup: UP is no longer undefined
- Run completeError if ipc messages conversion failed
- don't throw, instead return undefined
- Disabled passkey provider
- Throw error if no activeUserId was found
- removed comment
Co-authored-by: Anders Åberg <github@andersaberg.com>
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
…ntroller.swift Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
…/clients into passkey-window-working
…e.service.ts Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
UV is performed by UI, not the service
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #13784 +/- ##
==========================================
- Coverage 35.93% 35.88% -0.06%
==========================================
Files 3179 3179
Lines 93222 93361 +139
Branches 16989 16999 +10
==========================================
+ Hits 33502 33503 +1
- Misses 57123 57261 +138
Partials 2597 2597 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great job, no security vulnerabilities found in this Pull Request |