Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17933] Rename github-action group to no longer be minor-only #13799

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Mar 11, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17933

📔 Objective

Follow-up to #13234, which grouped the BRE and Platform github-actions dependencies. I neglected to catch that the group names no longer needed to have minor in the name, which would be misleading.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 changed the title Renamed groups and added consistent periods [PM-17933] Rename github-action group to no longer be minor-only Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.91%. Comparing base (b988993) to head (8223622).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13799      +/-   ##
==========================================
- Coverage   35.91%   35.91%   -0.01%     
==========================================
  Files        3181     3181              
  Lines       93331    93331              
  Branches    17013    17013              
==========================================
- Hits        33523    33516       -7     
- Misses      57209    57216       +7     
  Partials     2599     2599              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details40afcc22-d1b8-415c-bf71-25adc6209c2e

Great job, no security vulnerabilities found in this Pull Request

@trmartin4 trmartin4 marked this pull request as ready for review March 11, 2025 22:12
@trmartin4 trmartin4 requested a review from withinfocus March 11, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant