Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16100][A11y][Extension] Usernames not being read by screen readers like they used to be #13800

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jaasen-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16100

📔 Objective

This PR adds the username to the a11y attributes for the vault item autofill button. The addition of shareReplay to the clickItemsToAutofillVaultView observable was required in order to maintain the subscription across route changes as well as clickItemsToAutofillVaultView$.

📸 Screenshots

Screen.Recording.2025-03-11.at.3.36.31.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 35.91%. Comparing base (b988993) to head (82414fb).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...-list-items/autofill-vault-list-items.component.ts 0.00% 4 Missing ⚠️
.../services/vault-settings/vault-settings.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13800   +/-   ##
=======================================
  Coverage   35.91%   35.91%           
=======================================
  Files        3181     3181           
  Lines       93331    93330    -1     
  Branches    17013    17013           
=======================================
  Hits        33523    33523           
+ Misses      57209    57208    -1     
  Partials     2599     2599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details625ae75b-55d7-44c8-b032-005842e2231e

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant