Skip to content

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Sep 25, 2025

🎟️ Tracking

📔 Objective

We need to include Bitwarden-Client-Name and Bitwarden-Client-Version.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested review from a team as code owners September 25, 2025 16:05
@Hinton Hinton requested review from rr-bw and addisonbeck September 25, 2025 16:05
Copy link
Contributor

github-actions bot commented Sep 25, 2025

Logo
Checkmarx One – Scan Summary & Detailsf1928997-028f-4985-b39a-1f37ac5b98ab

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 32.35294% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.50%. Comparing base (9947387) to head (6f3ad8c).

Files with missing lines Patch % Lines
...rates/bitwarden-core/src/client/client_settings.rs 26.31% 14 Missing ⚠️
crates/bitwarden-core/src/client/client.rs 30.76% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
- Coverage   78.56%   78.50%   -0.06%     
==========================================
  Files         276      276              
  Lines       27379    27413      +34     
==========================================
+ Hits        21510    21521      +11     
- Misses       5869     5892      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hinton Hinton changed the title Add support for settingClient-Name and Client-Version Add headers Client-Name and Client-Version Sep 25, 2025
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants