[BEEEP] [PM-18518] Cleanup StripePaymentService #5435
+58
−1,573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonashendrickx
changed the title
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5435 +/- ##
==========================================
- Coverage 44.48% 44.37% -0.11%
==========================================
Files 1512 1513 +1
Lines 70281 69711 -570
Branches 6341 6279 -62
==========================================
- Hits 31261 30937 -324
+ Misses 37674 37451 -223
+ Partials 1346 1323 -23 ☔ View full report in Codecov by Sentry. |
| Task<bool> HasSecretsManagerStandalone(Organization organization); | ||
| Task<(DateTime?, DateTime?)> GetSuspensionDateAsync(Stripe.Subscription subscription); |
There was a problem hiding this comment.
This one's implementation can be made private
There was a problem hiding this comment.
Forgot that one. It's fixed. Moved a few other methods out that could be made extension methods.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-18518
📔 Objective
This code doesn't seem to be referenced anywhere anymore and can likely be safely deleted.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes