Use new helper method for file status #5488
Annotations
17 errors and 5 warnings
lint:
app/jobs/file_scan_job.rb#L13
Performance/StringIdentifierArgument: Use `:"on_scan_#{attribute_name}"` instead of `"on_scan_#{attribute_name}"`.
|
lint:
app/jobs/file_scan_job.rb#L27
Performance/StringIdentifierArgument: Use `:"on_scan_#{attribute_name}"` instead of `"on_scan_#{attribute_name}"`.
|
lint:
app/jobs/file_scan_job.rb#L34
Performance/StringIdentifierArgument: Use `:"on_scan_#{attribute_name}"` instead of `"on_scan_#{attribute_name}"`.
|
lint:
app/jobs/file_scan_job.rb#L40
Performance/StringIdentifierArgument: Use `:"on_scan_#{attribute_name}"` instead of `"on_scan_#{attribute_name}"`.
|
lint:
app/models/concerns/scan_files.rb#L11
Performance/StringIdentifierArgument: Use `:"scan_#{attr_name}!"` instead of `"scan_#{attr_name}!"`.
|
lint:
app/models/form_answer_attachment.rb#L7
Layout/TrailingWhitespace: Trailing whitespace detected.
|
lint:
config/initializers/virus_scanner.rb#L2
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
lint:
config/initializers/virus_scanner.rb#L3
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
lint:
config/initializers/virus_scanner.rb#L4
Style/TrailingCommaInArguments: Put a comma after the last parameter of a multiline method call.
|
lint:
config/initializers/virus_scanner.rb#L4
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
test:
spec/lib/virus_scanner_spec.rb#L41
VirusScanner.scan_file when the scan is successful returns the parsed scan result
Failure/Error: expect(result).to eq({malware: false, reason: nil, scan_time: 0.1})
expected: {:malware=>false, :reason=>nil, :scan_time=>0.1}
got: {:malware=>false}
(compared using ==)
Diff:
@@ -1,4 +1,2 @@
:malware => false,
-:reason => nil,
-:scan_time => 0.1,
|
test:
spec/lib/virus_scanner_spec.rb#L52
VirusScanner.scan_file when authentication fails raises an AuthenticationError
Failure/Error: expect { VirusScanner.scan_file(file_path) }.to raise_error(VirusScanner::AuthenticationError)
expected VirusScanner::AuthenticationError but nothing was raised
|
test:
spec/lib/virus_scanner_spec.rb#L62
VirusScanner.scan_file when the file is too large raises a FileTooLargeError
Failure/Error: expect { VirusScanner.scan_file(file_path) }.to raise_error(VirusScanner::FileTooLargeError)
expected VirusScanner::FileTooLargeError but nothing was raised
|
test:
spec/lib/virus_scanner_spec.rb#L73
VirusScanner.scan_file when an unexpected error occurs raises a ScanError
Failure/Error: expect { VirusScanner.scan_file(file_path) }.to raise_error(VirusScanner::ScanError, /Unexpected error: 500 Internal Server Error/)
expected VirusScanner::ScanError with message matching /Unexpected error: 500 Internal Server Error/ but nothing was raised
|
test:
spec/models/form_answer_attachment_spec.rb#L19
FormAnswerAttachment scan should not scan if the file is infected and removed
Failure/Error: expect_any_instance_of(FormAnswerAttachment).not_to receive(:scan_file_without_cleanup!)
FormAnswerAttachment does not implement #scan_file_without_cleanup!
|
test:
spec/services/rescan_service_spec.rb#L17
RescanService.rescan_model rescans unresolved files
Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { |failure, _opts| raise failure }
Exactly one instance should have received the following message(s) but didn't: scan_attachment!
|
test
Process completed with exit code 1.
|
test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2, actions/setup-node@v2-beta. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
test
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v2, actions/setup-node@v2-beta. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
test:
spec/features/users/form_answers/audit_certificate_request_spec.rb#L59
Verification of Commercial Figures
As a User
I want to be able to download an Verification of Commercial Figures
So that I can check, complete it and then upload it to application
Download Verification of Commercial Figures prefilled with my financial data should generate pdf file
Skipped: Temporarily skipped with xit
|
test:
spec/models/audit_log_spec.rb#L4
AuditLog add some examples to (or delete) /home/runner/work/qae/qae/spec/models/audit_log_spec.rb
Skipped: Not yet implemented
|
test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|