Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Replace Poxa with Action Cable #3105

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sammo1235
Copy link
Contributor

@sammo1235 sammo1235 commented Oct 11, 2024

📝 A short description of the changes

  • A very rough draft
  • Includes basic behaviour:
  • Two users cannot edit the same form at the same time
  • If one user moves on to a new section (step) of the form, then then previous section is released for editing for the next user in the queue
  • blocks a user from editing when they have two tabs of the same form opened.

I haven't fully worked out all the expected behaviours of the exiting implementation, so this may not exactly match what is needed.

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

  • Remove Pusher ENV vars and setup code.
  • Allow action cable to talk to Redis (setup should be straightforward)

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

@@ -842,7 +842,7 @@ window.FormValidation =
qRef = question.attr("data-question_ref")
qTitle = $.trim(question.find("h2").first().text())

if typeof console != "undefined"
if typeof console != "undefined" && false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TODO] remove once testing is complete - this output will muddy the waters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant