Modify validations behaviour

[sammo1235]

See ticket for changes need, they do a good job of explaining the issues this PR attempts to solve. There is also a list of form questions this is relevant to (basically they are date, financial info, personal details and previous award wins).

📝 A short description of the changes

• If form starts off empty, then we don't add validation errors for all the inputs the user has not yet touched.
• however, if we go back and delete an input, then it should show the validation error for that input.
• If the user navigates between different steps of the form (using save or the navigation menu on the left) then all validation errors should show, as before. However, now the behaviour has changed to only remove validation errors for the inputs that the user has touched, not clearing them wholesale like before.

There are two main modes to understand when reviewing the code - @validate_only_touched_inputs will be false when navigating around the different form steps (because we want to validate everything) and will be true once they start to interact with the inputs on a form (since we only care about validating what they touch).

🔗 Link to the relevant story (or stories)

• https://app.asana.com/0/1200504523179345/1207272963176223/f

Deployment implications

• Very little, this is just JS changes

✅ Checklist

• Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
• I have checked that commit messages make sense and explain the reasoning for each change
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

[matthewford]

I like the fact that this is a JS change only, which means there should be little knock-on effects on updating the form in later workflow steps.

[sammo1235]

There are probably cleaner ways of doing this in coffee

[matthewford]

Suggested change

	questionYearTouched = !!question.find('.js-date-input-year.dirty').length
	questionMonthTouched = !!question.find(".js-date-input-month.dirty").length
	questionDayTouched = !!question.find(".js-date-input-day.dirty").length
	allTouched = questionYearTouched && questionMonthTouched && questionDayTouched
	[yearTouched, monthTouched, dayTouched] = ['.js-date-input-year', '.js-date-input-month', '.js-date-input-day'].map (cls) ->
	!!question.find("#{cls}.dirty").length
	allTouched = yearTouched and monthTouched and dayTouched

It's not really much cleaner, though; I prefer the simplicity.

[sammo1235]

Since we now don't clear the entire question block for validation error before revalidating, we have to be careful not to add duplicate errors to the same elements