Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse edits #179

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Parse edits #179

wants to merge 17 commits into from

Conversation

spizwhiz
Copy link

@spizwhiz spizwhiz commented Jul 20, 2020

Implemented changes to parsing.py as discussed in #176. Changed notation for hydrates to ":" instead of "."

changed html, latex, and unicode parsing to match changes

@spizwhiz
Copy link
Author

Well, I think I have the parsing.py and associated test issues sorted. I got stuck on the balancing and reaction modules, and think it would be best if someone more familiar with those could help out. For now, I have the code doing what I need for my purposes but am happy to help finish this up where I can.

@bjodah
Copy link
Owner

bjodah commented Aug 8, 2020

Thank you for working on this. This looks good, but unfortunately with the exception for radicals. I had forgot I used "." to indicate radicals. Here a colon is confusing, and would probably be interpreted as a diradical. The only way I see around this issue is to parse "." in a context sensitive manner, i.e. when between two numbers: it's a decimal point, and when leading (and in front of a letter?) it's a radical. Perhaps someone interested in seeing this getting into master will take over the work here.

@jeremyagray
Copy link
Collaborator

jeremyagray commented Aug 8, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants