feat(common): Add support for loadBalancerClass #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjw-s
force-pushed
the
common-3.4.0
branch
6 times, most recently
from
d4d1efc to
f45d14e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Added
Added support for setting the loadBalancerClass introduced in Kubernetes 1.24
See: https://kubernetes.io/docs/concepts/services-networking/service/#load-balancer-class
Benefits
Allows multiple different types of LBs to be used. Also allows LBs that need a class to be set to be used. (e.g. Cilium Node IPAM See: https://docs.cilium.io/en/latest/network/node-ipam/ )
Checklist
I have not increased the chart version as I saw you're about to release 3.4.0
Chart.yamlhas been bumped according to Semantic Versioning.artifacthub.io/changeschangelog annotation has been updated inChart.yaml. See Artifact Hub documentation for more info.I have not added the variable to the values.yaml file as other variables of this depth are also not in the values yaml (e.g. loadBalancerIP)
values.yamlfile.