Skip to content

unique_ptr and rework UUID generation #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 4, 2024
Merged

unique_ptr and rework UUID generation #12

merged 4 commits into from
Sep 4, 2024

Conversation

black-sliver
Copy link
Owner

@black-sliver black-sliver commented Jan 5, 2024

  • use unique_ptr for auto-created data storage and websocket
  • fix AP_NO_DEFAULT_DATA_PACKAGE_STORE code path not working
  • rework UUID generation
    • use fstream instead of FILE*, hopefully getting rid of MSVC warnings
    • when a UUID (cache) filename is supplied, this now generates 256 different UUIDs based on a new optional "hostname" parameter. This can be used to send different string to different rooms/hosts and, if used, should be the url (host:port) without ws:// or wss://
    • if no filename is supplied, this generates a random one every time, which is currently completely fine (until we reuse it for competitive or the like)
    • the updated cache file should be forwards and backwards compatible
  • Deprecate get_location_name without game

also fixes AP_NO_DEFAULT_DATA_PACKAGE_STORE code path
also minor docs cleanup
@black-sliver black-sliver merged commit 15cf63c into main Sep 4, 2024
2 checks passed
@black-sliver black-sliver deleted the next branch September 4, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant