This repository was archived by the owner on Dec 8, 2022. It is now read-only.
Support double-click to highlight keyinfo value/label individually#1129
Open
ShaydeNofziger wants to merge 1 commit intoblackbaud:masterfrom
Open
Support double-click to highlight keyinfo value/label individually#1129ShaydeNofziger wants to merge 1 commit intoblackbaud:masterfrom
ShaydeNofziger wants to merge 1 commit intoblackbaud:masterfrom
Conversation
Support double-click to highlight on value without including label value
|
|
Collaborator
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 5a23ce8 (Please note that this is a fully automated comment.) |
Author
|
Screenshots of how this looks after double-clicking the key-value: Before fix: After fix: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
divtags without a separating character (newline or space, for example) causes a "double-click" to highlight the first word of the second div. Add a space after thebb-key-info-valuediv to prevent the first word in thebb-key-info-labeldiv from being highlighted on double-click. Likewise, this prevents the last word of thebb-key-info-valuediv from being highlighted upon double-click of thebb-key-info-labeldiv.This is re-produceable in latest version of Edge and Chrome on Windows 10. I have tested the fix in both browsers.
Alternative to a space after the
bb-key-info-valuewould be a single newline between the two divs. That may be more readable to future maintainers.I'll leave it up to maintainers as to which is preferred (space vs newline).