Skip to content

Release/0.3.0 #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 15, 2024
Merged

Release/0.3.0 #113

merged 11 commits into from
Jul 15, 2024

Conversation

lcc3108
Copy link
Member

@lcc3108 lcc3108 commented Jul 12, 2024

Summary

release/0.3.0
fix

Summary by CodeRabbit

  • 새로운 기능

    • 쿼리 모드 선택을 위한 접근성 향상(라디오 버튼 그룹에 aria-label 속성 추가).
  • 버그 수정

    • 쿼리 편집기에서 불필요한 console.log 제거.
  • 테스트

    • 시간 시리즈, 테이블, 실시간 데이터를 위한 쿼리 모드 선택 시나리오 업데이트.
    • 메트릭 및 시간 차원 선택 시나리오 조정.
  • 기타

    • 패키지 버전 업데이트: 0.2.3에서 0.3.0으로.
    • Grafana 종속성 버전 제약 조건 업데이트: >=9 <12.0.0.

Copy link
Contributor

coderabbitai bot commented Jul 12, 2024

Warning

Rate limit exceeded

@lcc3108 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 16 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 7126a30 and 88769b0.

개요

이번 변경 사항은 package.json의 버전 업데이트, 몇몇 함수와 로그 문구의 수정, 접근성 향상을 위한 속성 추가, Grafana 종속성 버전 업데이트, 그리고 테스트 스크립트의 여러 수정 사항을 포함합니다. 특히, 새로운 기능 도입 없이 주로 기존 기능의 개선과 유지보수에 초점을 맞췄습니다.

변경 사항

파일 변경 요약
package.json 버전이 "0.2.3"에서 "0.3.0"으로 증가.
pkg/gav4/grafana.go transformReportsResponseToDataFrames 함수의 기본 케이스가 transformReportToDataFrames로 수정됨.
src/QueryEditorCommon.tsx console.log("common") 문구 제거.
src/QueryEditorGA4.tsx RadioButtonGroup 컴포넌트에 aria-label 속성 추가.
src/plugin.json grafanaDependency 버전이 >=7.3.x <11.0.0에서 >=9 <12.0.0으로 업데이트.
tests/.../queryEdiyor.spec.ts 다양한 시나리오에서 쿼리 모드 선택을 업데이트하고, UI 요소 상호작용을 조정.
| `tests/.../queryEdiyor.spec.ts` |
| - `await explorePage.getQueryEditorRow('A').getByLabel('query-mode').getByLabel('Time Series').check()` |
| - `await explorePage.getQueryEditorRow('A').getByLabel('query-mode').getByLabel('Table').check()` |
| - `await explorePage.getQueryEditorRow('A').getByLabel('query-mode').getByLabel('Realtime').check()` |
| - `await explorePage.getQueryEditorRow('A').getByLabel('time-dimension').click()` |
| - `await explorePage.getQueryEditorRow('A').getByLabel('time-dimension')).toBeDisabled()` |

시퀀스 다이어그램

새로운 코드는 더 빛나,
버전 업그레이드, 잘했다!
소소한 수정, 큰 변화 없이,
더 나은 코드, 기대 가득히.
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f24ffc6 and 4ec1445.

Files selected for processing (6)
  • package.json (1 hunks)
  • pkg/gav4/grafana.go (1 hunks)
  • src/QueryEditorCommon.tsx (1 hunks)
  • src/QueryEditorGA4.tsx (1 hunks)
  • src/plugin.json (1 hunks)
  • tests/query/queryEdiyor.spec.ts (3 hunks)
Files skipped from review due to trivial changes (2)
  • src/QueryEditorCommon.tsx
  • src/plugin.json
Additional comments not posted (9)
package.json (1)

3-3: 버전 업데이트 확인

버전이 "0.2.3"에서 "0.3.0"으로 업데이트되었습니다. 새로운 릴리스를 위한 변경 사항입니다.

tests/query/queryEdiyor.spec.ts (6)

9-9: 'Time Series' 쿼리 모드 선택 확인

'Time Series' 쿼리 모드가 올바르게 선택되었는지 확인하는 코드가 추가되었습니다.


21-21: 시간 차원 선택 확인

시간 차원이 올바르게 선택되었는지 확인하는 코드가 추가되었습니다.


44-44: 'Table' 쿼리 모드 선택 확인

'Table' 쿼리 모드가 올바르게 선택되었는지 확인하는 코드가 추가되었습니다.


55-55: 시간 차원 선택 확인

시간 차원이 올바르게 선택되었는지 확인하는 코드가 추가되었습니다.


78-78: 'Realtime' 쿼리 모드 선택 확인

'Realtime' 쿼리 모드가 올바르게 선택되었는지 확인하는 코드가 추가되었습니다.


90-90: 시간 차원 비활성화 확인

'Realtime' 모드에서 시간 차원이 비활성화되었는지 확인하는 코드가 추가되었습니다.

pkg/gav4/grafana.go (1)

215-215: 기본 케이스에서 함수 할당 변경

기본 케이스에서 transformReportToDataFramesFntransformReportToDataFrames로 할당되도록 변경되었습니다.

src/QueryEditorGA4.tsx (1)

331-331: 접근성 향상

RadioButtonGroup 컴포넌트에 aria-label 속성이 추가되어 접근성이 향상되었습니다.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4ec1445 and 7c4b850.

Files selected for processing (1)
  • tests/query/queryEdiyor.spec.ts (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • tests/query/queryEdiyor.spec.ts

grafana version별로 레이블이 달라서 분기처리
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7c4b850 and 7126a30.

Files selected for processing (1)
  • tests/query/queryEdiyor.spec.ts (3 hunks)
Additional comments not posted (3)
tests/query/queryEdiyor.spec.ts (3)

50-55: 호환성 확인

query-mode 레이블이 없을 경우 텍스트 기반 선택기로 대체하는 방식으로 Grafana 버전 호환성을 처리하고 있습니다. 이 접근 방식이 올바르게 작동하는지 확인해야 합니다.


88-93: 호환성 확인

query-mode 레이블이 없을 경우 텍스트 기반 선택기로 대체하는 방식으로 Grafana 버전 호환성을 처리하고 있습니다. 이 접근 방식이 올바르게 작동하는지 확인해야 합니다.


10-16: 호환성 확인

query-mode 레이블이 없을 경우 텍스트 기반 선택기로 대체하는 방식으로 Grafana 버전 호환성을 처리하고 있습니다. 이 접근 방식이 올바르게 작동하는지 확인해야 합니다.

@lcc3108
Copy link
Member Author

lcc3108 commented Jul 15, 2024

@coderabbitai Please create a release note compared to the v0.2.3 tag

Copy link
Contributor

coderabbitai bot commented Jul 15, 2024

Oops, something went wrong! Please try again later. 🐰 💔

@lcc3108 lcc3108 merged commit 3696f59 into master Jul 15, 2024
7 checks passed
@lcc3108 lcc3108 deleted the release/0.3.0 branch July 15, 2024 06:42
@coderabbitai coderabbitai bot mentioned this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant